Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline correction settings #2265

Merged
merged 9 commits into from
May 31, 2020
Merged

Streamline correction settings #2265

merged 9 commits into from
May 31, 2020

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented May 29, 2020

fix? #2231

  • group correction settings for known types, add webui detection, relax constraints for values
  • de-hardcode webui magnitude and error types

@davebuk
Copy link
Contributor

davebuk commented May 29, 2020

Did you want me to try your code and build over the weekend or shall I wait until you have merged into the main xoseperez dev code?

@mcspr
Copy link
Collaborator Author

mcspr commented May 29, 2020

If you can try it out like this, please do. It would be good to verify nothing else in the sensors breaks because of this change.

@davebuk
Copy link
Contributor

davebuk commented May 30, 2020

Looking good!
These are from a BME280.
BEFORE
bmx01
AFTER
bmx02

The order is which Pressure and Humidity are shown between the status page and sensor page are different but you wouldn't normally be looking at both pages at the same time.

MQTT values are correct and seen by openHAB.

I can try a Lux later today if you like?

@davebuk
Copy link
Contributor

davebuk commented May 30, 2020

Second device with BH1750 sensor.
BEORE
lux01
AFTER POSITIVE CORRECTION
lux02
AFTER NEGATIVE CORRECTION
lux03

@mcspr
Copy link
Collaborator Author

mcspr commented May 30, 2020

Thanks!

I did not notice the order. Corrections page is generated outside of sensor class, so numerical sorting comes into play (Temperature, Humidity, Pressure). Sensor though uses a special logic to exclude humidity when sensor happens to be BMP280, so naturally it is the last one.

@mcspr mcspr merged commit d9cb35f into xoseperez:dev May 31, 2020
@mcspr mcspr deleted the sns/correct branch May 31, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants